[wget-notify] COMMIT: r2243 - in /branches/bugs/b20323: src/ tests/

[Micah Cowan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Micah Cowan wrote:
> Mauro Tortonesi wrote:
>> On Mon, 09 Jul 2007 17:24:12 -0700 Micah Cowan <micah at cowan.name>
>> wrote:
> 
>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>>>
>>> mtortonesi at ing.unife.it wrote:
>>>> Author: mtortonesi Date: Mon Jul  9 16:28:54 2007 New Revision:
>>>> 2243
>>>>
>>>> Log: Fix and testcases for bug #20323: skip preliminary HTTP HEAD
>>>> request if either -O or --no-content-disposition are given, and
>>>> neither --spider and -N are given.
>>>>
>>> Is this bug branch also going to address the "don't issue HEAD
>>> request if timestamping, and no local file exists" issue, which is
>>> what the actual bug report title refers to? :)
>> of course. in fact, http.c contains the fix. it's just 3-4 lines, but
>> it works. as you can guess, i tested it quite a bit ;-)
> 
> As far as I can tell, http.c does not contain that fix, and wget still
> fails to behave in that way.
> 
> In fact, at the moment, it seems that in some cases, HEAD is issued, and
> _not_ followed with a GET (so no file is downloaded).
> 
> To be clear: the logic should be that HEAD is issued _only_ if all of
> the following are true:
> 
>   1. We are timestamping, and
>   2. Local version of the file exists.
> 
> (I'm not _entirely_ sure how --spider enters into this, as I'm not
> completely certain of what exactly --spider does).

Possibly, (1) should be ammended to: We are timestamping OR enabling
content disposition...

Also, I was wrong about content-disposition not having an effect: my
logic was off. The tests I should have been doing are:

$ wget --debug -e contentdisposition=no www.gnu.org/home.html

and

$ wget --debug -N -e contentdisposition=no www.gnu.org/home.html

Of these two, the former works as expected (no HEAD), whereas the latter
still issues a HEAD in the event that home.html does not exist.

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer...
http://micah.cowan.name/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGk/kU7M8hyUobTrERCGEkAJ45Fvg6s7t+ODVcQ8h05/EKnxnS7gCfRKzE
vfEr60HyeS6h6R6FXAv+0VE=
=God4
-----END PGP SIGNATURE-----